Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add jest-mongodb example #5571

Merged
merged 5 commits into from
Feb 15, 2018
Merged

docs: add jest-mongodb example #5571

merged 5 commits into from
Feb 15, 2018

Conversation

vladholubiev
Copy link
Contributor

Summary

Inspired by #5093 I added an example how to setup jest with mongodb in-memory server to write tests

Test plan

Tests are running in CI using example: https://circleci.com/gh/vladgolubev/jest-mongodb

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Feb 15, 2018

Codecov Report

Merging #5571 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5571   +/-   ##
=======================================
  Coverage   61.72%   61.72%           
=======================================
  Files         213      213           
  Lines        7169     7169           
  Branches        4        4           
=======================================
  Hits         4425     4425           
  Misses       2743     2743           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35b78b...b01beb3. Read the comment docs.

docs/MongoDB.md Outdated
```

Note: you may need to modify test script to run jest sequentially, like that:
`jest --runInBand --forceExit`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forceExit should not be necessary unless the db is not clean up properly - which it should be.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup? We cannot advice that in a tutorial, that's just an escape hatch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn auto correct, pardon that question mark

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I added this at the very beginning, might be not needed anymore, let me see

Copy link
Contributor Author

@vladholubiev vladholubiev Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, found the problem and fixed, no need for --forceExit now

@KnupMan
Copy link

KnupMan commented Feb 15, 2018

No more failing tests because of timeout, like it was with mockgo 👍

docs/MongoDB.md Outdated
};
```

Then we need a custom Test Environment for puppeteer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say "for Mongo"?

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed the fix, looks great!

@cpojer cpojer merged commit fcdf071 into jestjs:master Feb 15, 2018
@cpojer
Copy link
Member

cpojer commented Feb 15, 2018

Thanks for improving Jest's documentation!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants