-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #5531 #5532
fixes #5531 #5532
Conversation
Thank you! Can you add an integration test for this behavior? |
@cpojer I was just looking if I can. Should be fairly trivial-I'll just let it run an empty so yeah, I'll clone this and write it. |
Hey @capaj! Mind adding the test and fixing CI? |
because we can have a "describe" block but no "it" blocks inside
@cpojer added a unit test, rebased on top of current master |
Codecov Report
@@ Coverage Diff @@
## master #5532 +/- ##
==========================================
+ Coverage 63.16% 63.63% +0.47%
==========================================
Files 216 216
Lines 7913 7911 -2
Branches 3 3
==========================================
+ Hits 4998 5034 +36
+ Misses 2914 2876 -38
Partials 1 1
Continue to review full report at Codecov.
|
Nice, thank you for following up on this! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
because we can have a "describe" block but no "it" blocks inside
Fixes #5531