Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #5531 #5532

Merged
merged 1 commit into from
Feb 28, 2018
Merged

fixes #5531 #5532

merged 1 commit into from
Feb 28, 2018

Conversation

capaj
Copy link
Contributor

@capaj capaj commented Feb 12, 2018

because we can have a "describe" block but no "it" blocks inside

Fixes #5531

@cpojer
Copy link
Member

cpojer commented Feb 12, 2018

Thank you! Can you add an integration test for this behavior?

@capaj
Copy link
Contributor Author

capaj commented Feb 12, 2018

@cpojer I was just looking if I can. Should be fairly trivial-I'll just let it run an empty describe block like here: https://github.com/facebook/jest/blob/master/packages/jest-jasmine2/src/__tests__/integration/lifecycle_hooks_test.js

so yeah, I'll clone this and write it.

@cpojer
Copy link
Member

cpojer commented Feb 23, 2018

Hey @capaj! Mind adding the test and fixing CI?

because we can have a "describe" block but no "it" blocks inside
@capaj
Copy link
Contributor Author

capaj commented Feb 28, 2018

@cpojer added a unit test, rebased on top of current master

@codecov-io
Copy link

Codecov Report

Merging #5532 into master will increase coverage by 0.47%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5532      +/-   ##
==========================================
+ Coverage   63.16%   63.63%   +0.47%     
==========================================
  Files         216      216              
  Lines        7913     7911       -2     
  Branches        3        3              
==========================================
+ Hits         4998     5034      +36     
+ Misses       2914     2876      -38     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-jasmine2/src/jasmine/Suite.js 42.35% <100%> (+42.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f59552...348dad7. Read the comment docs.

@cpojer cpojer merged commit 48560bf into jestjs:master Feb 28, 2018
@cpojer
Copy link
Member

cpojer commented Feb 28, 2018

Nice, thank you for following up on this!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'result' of undefined at isAfterAll when I comment out all "it" blocks
4 participants