docs(changelog): mark #3672 as breaking #5115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Dec 18, 2017
| @@ -102,7 +102,7 @@ None | |||
| ([#4593](https://github.com/facebook/jest/pull/4593)) | |||
| * `[jest-snapshot]` [**BREAKING**] Concatenate name of test and snapshot | |||
| ([#4460](https://github.com/facebook/jest/pull/4460)) | |||
| * `[jest-cli]` Add an option to fail if no tests are found | |||
| * `[jest-cli]` [**BREAKING**] Fail if no tests are found | |||
There was a problem hiding this comment.
We flipped it midways through the PR, so the title of it is misleading
|
Yes, please! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref #5112. Maybe it would have helped if it was marked as breaking in the changelog, and they would have checked it and seen the new option for the old behavior.
Test plan
Docs only