Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prettier lint errors in watch_plugin_registry.js #4871

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

pedrottimark
Copy link
Contributor

Summary

Local yarn lint now reports 4 errors because upgrade to prettier 1.8 in #4852 was merged after #4841 was opened:

  38:30  error  Replace `pluginModulePath` with `⏎··········pluginModulePath⏎········`  prettier/prettier
  48:30  error  Replace `pluginModulePath` with `⏎··········pluginModulePath⏎········`  prettier/prettier
  53:30  error  Replace `pluginModulePath` with `⏎··········pluginModulePath⏎········`  prettier/prettier
  61:30  error  Replace `pluginModulePath` with `⏎··········pluginModulePath⏎········`  prettier/prettier

Test plan

yarn lint

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not a fan of this... :(

@pedrottimark
Copy link
Contributor Author

Yeah, agree :(

@cpojer
Copy link
Member

cpojer commented Nov 10, 2017

I think one way to fix it is by breaking the string up manually. I'm also not a fan of using substitution for line breaks, but oh well… (cc @vjeux so I have somebody to rant to).

@cpojer cpojer merged commit 7693d4a into jestjs:master Nov 10, 2017
@pedrottimark pedrottimark deleted the fix-prettier-watch branch November 10, 2017 16:51
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@9c52d27). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4871   +/-   ##
=========================================
  Coverage          ?   59.75%           
=========================================
  Files             ?      195           
  Lines             ?     6533           
  Branches          ?        4           
=========================================
  Hits              ?     3904           
  Misses            ?     2629           
  Partials          ?        0
Impacted Files Coverage Δ
packages/jest-cli/src/lib/watch_plugin_registry.js 73.68% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c52d27...6629da7. Read the comment docs.

@vjeux
Copy link
Contributor

vjeux commented Nov 10, 2017

Yeah, template literals are annoying. I think that this update is good, it gives more opportunities to break so that it remains under 80 columns but without trying to break at crazy places like in the middle of a member expression.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants