Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let transformers adjust cache key based on mapCoverage #4187

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

jwbay
Copy link
Contributor

@jwbay jwbay commented Aug 2, 2017

Summary
The first time someone flips on mapCoverage, they'll have a bad time if their transformer implements a getCacheKey since the flag is not passed to it. There's a chance this PR would fix issues like #4163. I ran into something similar and nuking the cache manually fixed it.

Test plan
Test added

@codecov-io
Copy link

Codecov Report

Merging #4187 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4187   +/-   ##
=======================================
  Coverage   60.25%   60.25%           
=======================================
  Files         198      198           
  Lines        6781     6781           
  Branches        6        6           
=======================================
  Hits         4086     4086           
  Misses       2692     2692           
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-runtime/src/script_transformer.js 89.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5ccd3...d68436c. Read the comment docs.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cpojer cpojer merged commit 6e8d425 into jestjs:master Aug 3, 2017
@jwbay jwbay deleted the cachekey branch August 3, 2017 14:44
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants