Use eslint plugins to run prettier #3971
Conversation
| @@ -10,6 +10,8 @@ module.exports = { | |||
| extends: [ | |||
| './packages/eslint-config-fb-strict/index.js', | |||
| 'plugin:import/errors', | |||
| 'prettier', | |||
| 'prettier/flowtype', | |||
There was a problem hiding this comment.
Doesn't seem like any flowtype style rules were applied, so might want to remove this
|
This is great, thank you so much @SimenB. Improving the tooling and structure of the project always pays off long-term and helps everybody else make better contributions. |
Codecov Report
@@ Coverage Diff @@
## master #3971 +/- ##
=======================================
Coverage 59.85% 59.85%
=======================================
Files 196 196
Lines 6760 6760
Branches 6 6
=======================================
Hits 4046 4046
Misses 2711 2711
Partials 3 3
Continue to review full report at Codecov.
|
* Use eslint plugins to run prettier Fixes jestjs#3575 * Remove redundant prettier script file * Don't run prettier on markdown files (they are not fixable)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #3575
Test plan
Lint should pass