Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting #3946

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Fix linting #3946

merged 1 commit into from
Jun 30, 2017

Conversation

mjesun
Copy link
Contributor

@mjesun mjesun commented Jun 30, 2017

No description provided.

// We mock stderr (even if we do not use it right now on the tests) to avoid
// fake reporters created while testing to mess with the real output of the
// tests itself.
/* eslint-disable no-unused-vars */
let DefaultReporter;
let stdout;
let stderr;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the var and the lint rule.

@cpojer cpojer merged commit 9426521 into jestjs:master Jun 30, 2017
@mjesun mjesun mentioned this pull request Jun 30, 2017
mjesun added a commit that referenced this pull request Jun 30, 2017
* Revert "fix typo in snapshot testing documentation (#3948)"

This reverts commit d6998c2.

* Revert "Fix linting (#3946)"

This reverts commit 9426521.
mjesun added a commit that referenced this pull request Jun 30, 2017
…led. Fixes #3941" (#3951)

* Revert "fix typo in snapshot testing documentation (#3948)"

This reverts commit d6998c2.

* Revert "Fix linting (#3946)"

This reverts commit 9426521.

* Revert "Avoid writing to stdout in default reporter if --json is enabled. Fixes #3941 (#3945)"

This reverts commit 68d747d.
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Revert "fix typo in snapshot testing documentation (jestjs#3948)"

This reverts commit d6998c2.

* Revert "Fix linting (jestjs#3946)"

This reverts commit 9426521.
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
…led. Fixes jestjs#3941" (jestjs#3951)

* Revert "fix typo in snapshot testing documentation (jestjs#3948)"

This reverts commit d6998c2.

* Revert "Fix linting (jestjs#3946)"

This reverts commit 9426521.

* Revert "Avoid writing to stdout in default reporter if --json is enabled. Fixes jestjs#3941 (jestjs#3945)"

This reverts commit 68d747d.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants