Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all config filename patterns against rel paths #2

Closed
wants to merge 1 commit into from

Conversation

sophiebits
Copy link
Contributor

I think this makes more sense generally.

Test Plan: Run bin/jest.js in jest/ and in each example folder.

Test Plan: Run bin/jest.js in jest/ and in each example folder.
"testPathIgnorePatterns": ["<rootDir>/node_modules"]
"scriptPreprocessor": "preprocessor.js",
"unmockedModulePathPatterns": ["^node_modules/react/"],
"testPathIgnorePatterns": ["^node_modules/"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@cpojer
Copy link
Member

cpojer commented Oct 14, 2015

@spicyj would you mind rebasing this diff and making sure everything is green? I'd like to pull this in as part of 0.6.0 (Also add it to the changelog please).

@cpojer
Copy link
Member

cpojer commented Oct 14, 2015

Actually, it has been a while. I don't think it makes sense to break this behavior so we should probably support both patterns or keep only the one we are supporting currently.

@sophiebits
Copy link
Contributor Author

Whatever you like.

@cpojer
Copy link
Member

cpojer commented Oct 14, 2015

If you want to support both patterns, please update your PR. If not, feel free to close this PR.

@sophiebits
Copy link
Contributor Author

Not sure how that could work.

@sophiebits sophiebits closed this Oct 14, 2015
cpojer added a commit that referenced this pull request Jun 15, 2016
* Flowify reporters in jest-cli

* Cleanup some type annotations.
cpojer pushed a commit that referenced this pull request May 2, 2017
* Custom Reporters

this error is not letting me lint 100% safe

Reporter config 3 (#2)

* add custom reporters option in TestRunner

* add reporters option in jest-cli config

* add flowtype for reporters option

* add key for reporters in validConfig

* add noDefaultReporters option

noDefaultReporters option let's user turn
off all the reporters set by default

* Lint

* add unit tests for _addCustomReporters

* separate default reporters in method in TestRunner

* add tests for errors which are thrown

* add tests for .noDefaultReporters

* modify Error thrown for _addCustomReporters

* remove superfluous comment from TestRunner.js

* remove reporter tests from TestRunner-test.js

* add new custom reporters format in TestRunner.js

* update the format for adding customReporter

* add descriptive validations for reporters

* add reporters attibute in normalize.js

* add prettier to types

* Seperate out ReporterDispatcher in a file

* add elaborate messages for errors

* add Facebook Copyright header to ReporterDispatcher.js

* typecheck and lint properly

* correcting a condition in ReporterDispatcher

* rename method to `_shouldAddDefaultReporters`

* add integration tests for custom_reporters

* add more complete integration tests for reporters

* remove AggregatedResults.js

* remove any methods to be validated

* correct _addDefaultReporters call

* remove "reporters" validations from TestRunner.js

* add pretty validations for custom reporters

* remove comment

* add reporter validation in normalize.js

* keep comments precise remove unwanted

* check if reporters exist before validation

* pretty custom reporters

* prettier integration_tests

* prettier

* yarn prettier

* prettier

* Remove unnecessary comments from TestRunner.js

* make ReporterConfig type in types/Config simpler

* remove comments

* correct types and change method signatures

* remove bug from reporterValidationErrors.js

* make custom_reporters tests more concise

* fix lint error in website

this error is not letting me lint 100% safe

* finalize types for reporters

* yarn prettier

* remove .vscode folder

* all integration_tests are prettier now

* remove validateReporters call

* remove usage of \t in reporter validation errors

* change spread operator with usage of .apply

* modify custom_reporters integration_tests to suit node 4

* prettier validations

* prettier ❤️

* pretty lint

* update lock file

* Custom Reporters (merge/fix)

* Use jest-resolve to resolve reporters

* Minor cleanups
SimenB referenced this pull request in SimenB/jest Jun 13, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Custom Reporters

this error is not letting me lint 100% safe

Reporter config 3 (jestjs#2)

* add custom reporters option in TestRunner

* add reporters option in jest-cli config

* add flowtype for reporters option

* add key for reporters in validConfig

* add noDefaultReporters option

noDefaultReporters option let's user turn
off all the reporters set by default

* Lint

* add unit tests for _addCustomReporters

* separate default reporters in method in TestRunner

* add tests for errors which are thrown

* add tests for .noDefaultReporters

* modify Error thrown for _addCustomReporters

* remove superfluous comment from TestRunner.js

* remove reporter tests from TestRunner-test.js

* add new custom reporters format in TestRunner.js

* update the format for adding customReporter

* add descriptive validations for reporters

* add reporters attibute in normalize.js

* add prettier to types

* Seperate out ReporterDispatcher in a file

* add elaborate messages for errors

* add Facebook Copyright header to ReporterDispatcher.js

* typecheck and lint properly

* correcting a condition in ReporterDispatcher

* rename method to `_shouldAddDefaultReporters`

* add integration tests for custom_reporters

* add more complete integration tests for reporters

* remove AggregatedResults.js

* remove any methods to be validated

* correct _addDefaultReporters call

* remove "reporters" validations from TestRunner.js

* add pretty validations for custom reporters

* remove comment

* add reporter validation in normalize.js

* keep comments precise remove unwanted

* check if reporters exist before validation

* pretty custom reporters

* prettier integration_tests

* prettier

* yarn prettier

* prettier

* Remove unnecessary comments from TestRunner.js

* make ReporterConfig type in types/Config simpler

* remove comments

* correct types and change method signatures

* remove bug from reporterValidationErrors.js

* make custom_reporters tests more concise

* fix lint error in website

this error is not letting me lint 100% safe

* finalize types for reporters

* yarn prettier

* remove .vscode folder

* all integration_tests are prettier now

* remove validateReporters call

* remove usage of \t in reporter validation errors

* change spread operator with usage of .apply

* modify custom_reporters integration_tests to suit node 4

* prettier validations

* prettier ❤️

* pretty lint

* update lock file

* Custom Reporters (merge/fix)

* Use jest-resolve to resolve reporters

* Minor cleanups
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants