Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type of testFailureExitCode config option #15232

Merged
merged 4 commits into from
Aug 11, 2024
Merged

Conversation

k-rajat19
Copy link
Contributor

Summary

According to types testFailureExitCode can also take string values.

Test plan

Green CI

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit b2f9112
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/66b8a8ef3903ee0008e6c3b0
😎 Deploy Preview https://deploy-preview-15232--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member

SimenB commented Aug 8, 2024

That's just because all CLI arguments are strings. But we probably don't need to say that in the types, so real fix is probably to remove it from there?

@k-rajat19
Copy link
Contributor Author

That's just because all CLI arguments are strings. But we probably don't need to say that in the types, so real fix is probably to remove it from there?

that sounds more reasonable but it will be breaking for those who are already passing string?
that's why I thought to make change in the doc instead of changing types 😅

@k-rajat19 k-rajat19 changed the title docs: testFailureExitCode config option can also take string values docs: fix type of testFailureExitCode config option Aug 10, 2024
@k-rajat19 k-rajat19 changed the title docs: fix type of testFailureExitCode config option fix type of testFailureExitCode config option Aug 10, 2024
@SimenB
Copy link
Member

SimenB commented Aug 11, 2024

I doubt anybody's passing it, but if they do, it should be easy enough to change. This only changes the types anyways.

Mind adding a changelog entry?

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit d408ee0 into jestjs:main Aug 11, 2024
8 of 9 checks passed
@k-rajat19 k-rajat19 deleted the patch branch August 11, 2024 12:14
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants