Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-mock): added missing overload call signature #15183

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

k-rajat19
Copy link
Contributor

Summary

It seems like _makeComponent is missing an overload signature, I have added one and removed Typescript error comment.

Test plan

Green CI

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9950af8
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/66921b8882a4500008043ec0
😎 Deploy Preview https://deploy-preview-15183--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@SimenB SimenB merged commit c5a00aa into jestjs:main Jul 23, 2024
73 checks passed
@k-rajat19 k-rajat19 deleted the overload branch July 23, 2024 10:24
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants