feat: added an option to disable ts-node #15161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k-rajat19
changed the title
SimenB
requested changes
Jul 5, 2024
There was a problem hiding this comment.
thanks! could you add a changelog entry, and maybe update the docs? E.g. the ts-node mention in here could also mention this flag: https://jestjs.io/docs/configuration
SimenB
reviewed
Jul 12, 2024
e2e/__tests__/jest.config.ts.test.ts
Outdated
Comment on lines
84
to
92
| expect(stderr).toMatch('must be of type'); | ||
| expect(stderr).toMatch( | ||
| "TS2322: Type 'string' is not assignable to type 'number'.", | ||
| ); | ||
| expect(stderr).not.toMatch('Option "testTimeout" must be of type:'); | ||
| expect(exitCode).toBe(1); |
There was a problem hiding this comment.
this test didn't actually produce a type error
This reverts commit 2f89f20.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #14317
Added
DISABLE_TS_NODEenv variable to disable ts-node typecheckingTest plan
Tests are passing