fix: isolate esm async import bug

[eryue0220]

Summary

Fix: #14387

Test plan

test locally

 e2e/__tests__/asyncESMImport.test.ts
  ✓ runs test with async ESM import (282 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   1 passed, 1 total
Time:        0.514 s, estimated 1 s
Ran all test suites matching.

[netlify]

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	a06645e
🔍 Latest deploy log	https://app.netlify.com/sites/jestjs/deploys/64e353c77896880008faac97
😎 Deploy Preview	https://deploy-preview-14397--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mrazauskas]

Looks right, but the Test Plan went missing (;

Is it possible to add an e2e test? Hm.. As I was mentioning in the issue, there is no need to have "type": "module" in package.json. Simply await import() an .mjs file and run Jest with --experimental-vm-modules. That can be done like here:

jest/e2e/__tests__/resolveAsync.test.ts

Lines 11 to 14 in 0fd5b1c

	test('runs test with native ESM', () => {
	const {exitCode, stderr, stdout} = runJest('resolve-async', [], {
	nodeOptions: '--experimental-vm-modules --no-warnings',
	});

Or there is some reason, which I didn’t take into account?

[eryue0220]

Looks right, but the Test Plan went missing (;

Is it possible to add an e2e test? Hm.. As I was mentioning in the issue, there is no need to have "type": "module" in package.json. Simply await import() an .mjs file and run Jest with --experimental-vm-modules. That can be done like here:

jest/e2e/__tests__/resolveAsync.test.ts

Lines 11 to 14 in 0fd5b1c

	test('runs test with native ESM', () => {
	const {exitCode, stderr, stdout} = runJest('resolve-async', [], {
	nodeOptions: '--experimental-vm-modules --no-warnings',
	});

Or there is some reason, which I didn’t take into account?

Sorry, I don't remember it. I'll fix them.

[eryue0220]

Looks right, but the Test Plan went missing (;

Is it possible to add an e2e test? Hm.. As I was mentioning in the issue, there is no need to have "type": "module" in package.json. Simply await import() an .mjs file and run Jest with --experimental-vm-modules. That can be done like here:

jest/e2e/__tests__/resolveAsync.test.ts

Lines 11 to 14 in 0fd5b1c

	test('runs test with native ESM', () => {
	const {exitCode, stderr, stdout} = runJest('resolve-async', [], {
	nodeOptions: '--experimental-vm-modules --no-warnings',
	});

Or there is some reason, which I didn’t take into account?

I added test plan.

But the

[eryue0220]

I updated the test plan and the e2e test case.

[mrazauskas]

Thanks! It is looking good.

I checked out and tried out on different versions of Node locally. Could you push the suggested changes to see if that also works in CI?

[mrazauskas]

Suggested change

import {jest} from '@jest/globals';

[eryue0220]

This import could not remove, because the next code will use the api jest. isolateModulesAsync

[mrazauskas]

Thanks. Seems like CI is happy.

One setup detail could be polished. I left an inline comment.

[mrazauskas]

Sorry, I was going through again and notice few more details. Could you look at them, please?

[mrazauskas]

Hm.. Isn’t it enough to use the same _isolatedMockRegistry? Did you try that?

It was my idea about missing _isolatedESMModuleRegistry, but it can I was wrong. Here we can see that _isolatedMockRegistry was simply not used while loading ES modules. Sorry about slow thinking. Could you try to _isolatedMockRegistry everywhere?

[eryue0220]

Of course, it is possible. I originally thought it was intentionally differentiated because I saw that there was already an existing _isolatedModuleRegistry, moreover, I think it seems more appropriate.

[mrazauskas]

Yes! Simple and clear. Thanks for collaboration!

(CI fails are not related.)

[eryue0220]

can this pr be merged, if no other problems ? cc @SimenB @mrazauskas

[SimenB]

wonderful, thanks!

[SimenB]

https://github.com/jestjs/jest/releases/tag/v29.6.3

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.