[haste-map]: Ignore Sapling vcs directories #13674
Conversation
Summary: Ignore `.sl` directories in HasteMap. This will allow Sapling to be used with jest projects Test Plan: `packages/jest-haste-map/src/__tests__/index.test.js` similar testing plan to what's in jestjs#13673 Closes jestjs#13673
|
Hi @vegerot! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
| const {hasteFS} = await (await HasteMap.create(defaultConfig)).build(); | ||
| expect(hasteFS.matchFiles('.sl')).toEqual([]); |
There was a problem hiding this comment.
without the patch in index.ts this throws an error about "could not parse invalid JSON"
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Docs of |
|
That's haste-map, yeah |
|
@SimenB how's this? 🙂 |
|
@SimenB My CI pipeline is failing. Do you know why? |
|
@vegerot would you be up for adding full sapling support? e.g. to https://github.com/facebook/jest/tree/main/packages/jest-changed-files? Which would mean |
sure, why not? Do we have issues to track these already? |
|
Not as far as I know. Feel free to open one (or jump right to the pr) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Stack created with Sapling. Best reviewed with ReviewStack.
[haste-map]: Ignore Sapling vcs directories
Summary: Ignore
.sldirectories in HasteMap. This will allow Sapling to beused with jest projects
Test Plan:
packages/jest-haste-map/src/__tests__/index.test.jssimilartesting plan to what's in #13673
Closes #13673