Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link in blog post #12747

Merged
merged 1 commit into from
Apr 26, 2022
Merged

docs: fix broken link in blog post #12747

merged 1 commit into from
Apr 26, 2022

Conversation

Josh-Cena
Copy link
Contributor

Summary

Nice post! Fixed a little broken link 👍

Test plan

The link now redirects correctly

@Josh-Cena
Copy link
Contributor Author

It would be cool if we can exclude docs / website changes from triggering CI tests D:

@SimenB
Copy link
Member

SimenB commented Apr 26, 2022

Wanna run the linter, but yeah. 🔥 🌴

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit d312e0d into jestjs:main Apr 26, 2022
@@ -53,7 +53,7 @@ Jest now ships with a reporter to be used on GitHub Actions, which will use anno

![GitHub Actions test error screenshot](/img/blog/28-gh-actions-reporter.png)

You can activate this reporter by passing `github-actions` in the [`reporters` configuration option](docs/configuration#reporters-arraymodulename--modulename-options).
You can activate this reporter by passing `github-actions` in the [`reporters` configuration option](/docs/configuration#reporters-arraymodulename--modulename-options).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, would it be possible to use Configuration.md somehow here? then docusaurus would've told me the link was broken 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you can't link pages between plugins, as of now. We'll probably change that in v3, but no time for architectural changes in v2 now :( (facebook/docusaurus#6370)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks for the context!

@Josh-Cena Josh-Cena deleted the fix-link branch April 26, 2022 08:30
F3n67u pushed a commit to F3n67u/jest that referenced this pull request May 2, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants