Upgrade from source-map 0.6.1 to @cspotcode/source-map-consumer 0.8.0 #12486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Apr 21, 2022
| @@ -6,7 +6,7 @@ | |||
| "testEnvironment": "node" | |||
| }, | |||
| "dependencies": { | |||
| "handlebars": "^4.7.3", | |||
| "source-map": "^0.6.1" | |||
| "@cspotcode/source-map": "0.8.0", | |||
There was a problem hiding this comment.
|
Most of this PR has conflicts due to #12692. Only the e2e test that we'd want to do this in, I think? |
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
wat, |
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements #12485. I talked about the potential motivation there. Submitting this pull request makes it possible for a maintainer to run the full test matrix, if they want to.
Test plan
This code change will be valid if automated tests pass.