-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest-each): fixes error message with incorrect count of missing arguments #12464
Conversation
Hi @flakolefluk! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thanks for the PR @flakolefluk! Could you sign the CLA? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@SimenB I will as soon as I get confirmation from my employer on how to proceed. |
Hey @SimenB - there should be an email regarding the CLA sent to the cla@fb.com already from @jhampton getting @flakolefluk added to an executed CLA. Can you please confirm? |
I don't know, I don't have access 😅 Maybe @JoelMarcey can confirm? (And give the bot a kick if it's stuck?) |
@SimenB / @JoelMarcey is there any update on the CLA? thanks! |
tried merging in main, maybe that triggers something. if not, I'll try closing and reopening |
nope 🙁 I've tried to ping somebody at meta through other channels now 🤞 |
@SimenB any luck? |
No, repinged now 🤞 |
This should be good to go now, though might take a few hours for our tooling to detect it properly and update the PR (or me commenting might trigger it?). |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Woo! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
FIxes incorrect number of missing arguments in jest-each, when used with templates.
Test plan
should fail with a message showing 1 missing argument, however it is returning the number of arguments given in the incomplete row (2)