Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-each): fixes error message with incorrect count of missing arguments #12464

Merged
merged 6 commits into from
Apr 13, 2022

Conversation

flakolefluk
Copy link
Contributor

Summary

FIxes incorrect number of missing arguments in jest-each, when used with templates.

Test plan

   each`
      a    | b    | expected
      ${0} | ${0}
    `.test('returns $expected when given $a and $b', ({a, b, expected}) => {
      expect(a + b).toBe(expected);
    });

should fail with a message showing 1 missing argument, however it is returning the number of arguments given in the incomplete row (2)

@facebook-github-bot
Copy link
Contributor

Hi @flakolefluk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@flakolefluk flakolefluk marked this pull request as ready for review February 23, 2022 04:45
@SimenB SimenB requested a review from mattphillips February 23, 2022 07:20
@SimenB
Copy link
Member

SimenB commented Mar 1, 2022

Thanks for the PR @flakolefluk! Could you sign the CLA? 🙂

Copy link
Contributor

@mattphillips mattphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@flakolefluk
Copy link
Contributor Author

Thanks for the PR @flakolefluk! Could you sign the CLA? 🙂

@SimenB I will as soon as I get confirmation from my employer on how to proceed.

@dustinsgoodman
Copy link

Hey @SimenB - there should be an email regarding the CLA sent to the cla@fb.com already from @jhampton getting @flakolefluk added to an executed CLA. Can you please confirm?

@SimenB
Copy link
Member

SimenB commented Mar 2, 2022

I don't know, I don't have access 😅 Maybe @JoelMarcey can confirm? (And give the bot a kick if it's stuck?)

@flakolefluk
Copy link
Contributor Author

@SimenB / @JoelMarcey is there any update on the CLA? thanks!

@SimenB
Copy link
Member

SimenB commented Mar 24, 2022

tried merging in main, maybe that triggers something. if not, I'll try closing and reopening

@SimenB SimenB closed this Mar 24, 2022
@SimenB SimenB reopened this Mar 24, 2022
@SimenB
Copy link
Member

SimenB commented Mar 24, 2022

nope 🙁 I've tried to ping somebody at meta through other channels now 🤞

@dustinsgoodman
Copy link

@SimenB any luck?

@SimenB
Copy link
Member

SimenB commented Apr 12, 2022

No, repinged now 🤞

@zpao
Copy link
Contributor

zpao commented Apr 12, 2022

This should be good to go now, though might take a few hours for our tooling to detect it properly and update the PR (or me commenting might trigger it?).

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Apr 13, 2022

Woo!

@SimenB SimenB merged commit fb18e9a into jestjs:main Apr 13, 2022
@dustinsgoodman
Copy link

Thank you @zpao and @SimenB for pushing to get this merged!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants