-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: re-export AsymmetricMatcher
from @jest/expect
#12410
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
# @jest/expect | ||
|
||
This package extends `expect` library with `jest-snapshot` matchers. It export `jestExpect` object, which can be used as standalone replacement of `expect`, and `createJestExpect` factory function, which returns an instance of `jestExpect`. | ||
This package extends `expect` library with `jest-snapshot` matchers. It exports `jestExpect` object, which can be used as standalone replacement of `expect`. | ||
|
||
The `jestExpect` function used in [Jest](https://jestjs.io/). You can find its documentation [on Jest's website](https://jestjs.io/docs/expect). |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,9 +15,10 @@ import { | |
} from 'jest-snapshot'; | ||
import type {JestExpect} from './types'; | ||
|
||
export type {AsymmetricMatchers, MatcherFunction, MatcherState} from 'expect'; | ||
export type {JestExpect} from './types'; | ||
|
||
export function createJestExpect(): JestExpect { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think exporting this is super useful. if it proves to be it's easy to add in the future |
||
function createJestExpect(): JestExpect { | ||
expect.extend({ | ||
toMatchInlineSnapshot, | ||
toMatchSnapshot, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
*/ | ||
|
||
import type {AssertionError} from 'assert'; | ||
import type {JestExpect} from '@jest/expect'; | ||
import type {AsymmetricMatchers, JestExpect} from '@jest/expect'; | ||
import type CallTracker from './jasmine/CallTracker'; | ||
import type Env from './jasmine/Env'; | ||
import type JsApiReporter from './jasmine/JsApiReporter'; | ||
|
@@ -69,8 +69,7 @@ export type Jasmine = { | |
version: string; | ||
testPath: string; | ||
addMatchers: (matchers: JasmineMatchersObject) => void; | ||
} & JestExpect & | ||
typeof globalThis; | ||
} & AsymmetricMatchers & {process: NodeJS.Process}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
declare global { | ||
namespace NodeJS { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new module in itself isn't breaking 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm.. In a way
expect
received minimal breaking change. That was the reason.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I added a separate entry for it below. Any other breaking changes than the type removal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The breakage I had in mind is this funny line (;
https://github.com/facebook/jest/blob/199f9811ae68b15879cbe18b7ef7ebd61eefcf23/packages/expect/src/index.ts#L434
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. that probably should have
thrown
all along, not be a no-op. Can call it out, tho