Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fatal worker error message #11381

Merged
merged 3 commits into from
May 7, 2021
Merged

Improve fatal worker error message #11381

merged 3 commits into from
May 7, 2021

Conversation

scitech
Copy link
Contributor

@scitech scitech commented May 6, 2021

Summary

"Call retries were exceeded" is a bit obscure, with more information users could have an easier time tracking down bugs.

See also #8769

Test plan

Tests were updated

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB
Copy link
Member

SimenB commented May 7, 2021

Prettier is a bit unhappy, could you fix?

@ravigore

This comment has been minimized.

@scitech
Copy link
Contributor Author

scitech commented May 7, 2021

Prettier is a bit unhappy, could you fix?

All set now @SimenB. Thank you!

@SimenB SimenB merged commit 705af68 into jestjs:master May 7, 2021
@scitech scitech deleted the call-retries-messaging branch May 7, 2021 21:20
mprinc pushed a commit to mprinc/jest that referenced this pull request May 9, 2021
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants