-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watchman
fails if there is no .git
in the directory
#802
Comments
I think the description inside of Jest makes sense but it might make sense to add this to the top of https://facebook.github.io/watchman/docs/troubleshooting.html @wez what do you think? |
facebook/watchman#25 is the underlying issue; we use the .git dir for synchronization cookies, but can't tell if you remove it at runtime, and that breaks queries against that watch. If this is deemed a common enough issue to add special troubleshooting information, I'd rather we just fixed the underlying problem. This is totally out of scope for jest to deal with, FWIW, and I think the messaging currently shown by jest is reasonable; it shows the error returned by watchman (so it isn't opaque) and suggests places to go look for help. |
For more color, if you don't have a |
We now have more control over fixing this. We should just not use watchman if it throws. Here is what we could do:
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
should there be a more friendly error that fails before it goes to
watchman
?The text was updated successfully, but these errors were encountered: