-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.9.0-fb2 slow tests with jest.runCLI() via Gulp #722
Comments
Thanks! Do you have any ideas as to why this might be happening or could you help troubleshooting this a bit? :) |
I'm trying to find it out. Have you tried to reproduce this? |
Cache dir listings:
|
I have also noticed that the process doesn't quit when the tests are finished with fb1. I'll try to dig around tomorrow and see if it's a config-related bug. |
@yaycmyk What happens when you comment out this part: https://github.com/facebook/jest/blob/master/src/resolvers/HasteResolver.js#L117 ? |
Ah yeah, the process quit issue, we figured it out and I'll publish fb2 soon. |
👍 |
I'm pretty sure this is resolved with fb2. Can you try and let me know if it is still an issue? If you are using watchman, try |
Summary:Fixes #714, probably also #722 and also facebook/react-native#6019 Closes #724 Differential Revision: D2953708 fb-gh-sync-id: 110a30d6c11256644c8e4f7ab1d7b7cb5fa1b021 shipit-source-id: 110a30d6c11256644c8e4f7ab1d7b7cb5fa1b021
Process is quitting now :)
This example is very simple, and difference is minor: But on my real world project, each test takes ~10-12s with |
@cpojer reopen pls |
I'm afraid without a proper repro case I can't do much. The 200ms in the example is probably just variance. |
@cpojer do you know any big project with a lot of tests using Jest, in which we could check this? |
https://github.com/facebook/relay is a good benchmark. |
@cpojer thnx, I will try this |
https://github.com/irudoy/relay/tree/gulp-jest-test
|
thank you so much for making a repro! I'll take a look after the weekend. Would you mind telling me the difference between those two commands on your personal projects with 0.8.2? Were they both at the same (slow! :D ) speed? |
@cpojer hmm, |
Hey @irudoy would you mind sharing what the runtime of |
@irudoy is this still an issue? |
@cpojer unfortunately, I have not time to check this now |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I'm running tests with jest.runCLI() via Gulp, and it still takes a lot of time. Also, when tests have been passed, gulp task doesn't exit and loading CPU at 80%. If I run it with npm test, all is ok.
Example:
https://github.com/irudoy/jest/tree/master/examples/gulp
The text was updated successfully, but these errors were encountered: