-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshots are reported to be written but are not #5270
Comments
@versae Sorry, if I miss anything. Are you checking snapshots as part of PR? Snapshots should be included as part of PR (unless we explicitly allow CI to write snapshots back into the repo). Do you mind confirming this one? |
Sure. Yes, all other snapshots are being created correctly and checked in the repo. It's just the ones for the |
Closing the issue. It was related to mocking the filesystem module |
Still not good that we print that it's being written when it's not. Or that you have access to the same |
Reopen as per @SimenB comment. |
Also experiencing this bug https://travis-ci.org/stereobooster/react-ideal-image/jobs/394213438 Locally tests pass, but fail on Travis. Related stereobooster/react-ideal-image#38 |
I have the same bug like @stereobooster they works locally but fail on travis CI. All snapshots files are checked in the source control. |
@SimenB I think my issue and @stereobooster doesn't belong to this issue right? I opened #7094 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Do you want to request a feature or report a bug?
Report a bug.
What is the current behavior?
After running
yarn test -u --no-cache
/node_modules/.bin/jest test --all --updateSnapshot --no-cache
I see the message5 snapshots written
, but no snapshots are actually written anywhere.Therefore, when running with
--ci
in Travis it fails.If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can
yarn install
andyarn test
.No minimal repository, sorry. But this branch should serve as an example.
yarn install
andyarn test
is all you need to reproduce the error.What is the expected behavior?
It should write the snapshots in the
/webpack/__tests__/__snapshots__
folder.Please provide your exact Jest configuration and mention your Jest, node,
yarn/npm version and operating system.
Tried with the latest versions of everything, didn't make much different. Current config for the branch linked above is:
Versions:
The text was updated successfully, but these errors were encountered: