Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line before quitting watch mode #5150

Closed
lorenzos opened this issue Dec 21, 2017 · 2 comments
Closed

New line before quitting watch mode #5150

lorenzos opened this issue Dec 21, 2017 · 2 comments

Comments

@lorenzos
Copy link
Contributor

This is a tiny feature request. I don't think a PR is necessary, but I'd submit one if you want. Currently, when quitting watch mode using Q, CTRL+C or CTRL+D, process is terminated without printing a new line. This cause the current shell prompt to start mid-line, which not only is "ugly", but also buggy in some cases.

Fixing it should be trivial, placing outputStream.write("\n") before process.exit(0) in lines 164 and 207 of packages/jest-cli/src/watch.js.

@SimenB
Copy link
Member

SimenB commented Dec 21, 2017

PR welcome! :)

lorenzos added a commit to lorenzos/jest that referenced this issue Dec 21, 2017
@cpojer cpojer closed this as completed Dec 22, 2017
cpojer pushed a commit that referenced this issue Dec 22, 2017
* New line before quitting watch mode #5150

* New line before quitting watch mode (eslint fix)
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants