fix(jest-resolve): usage of node: imports for builtin modules

jestjs · Jul 24, 2021 · 7cea174 · 7cea174
1 parent 7a64ede
commit 7cea174
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 ### Fixes
 
+- `[jest-resolve]` Allow usage of `node:` URLs to load Node.js builtin modules. ([#11638](https://github.com/facebook/jest/pull/11638))
+
 ### Chore & Maintenance
 
 ### Performance

diff --git a/e2e/__tests__/__snapshots__/moduleNameMapper.test.ts.snap b/e2e/__tests__/__snapshots__/moduleNameMapper.test.ts.snap
@@ -41,7 +41,7 @@ FAIL __tests__/index.js
       12 | module.exports = () => 'test';
       13 |
 
-      at createNoMappedModuleFoundError (../../packages/jest-resolve/build/resolver.js:558:17)
+      at createNoMappedModuleFoundError (../../packages/jest-resolve/build/resolver.js:561:17)
       at Object.require (index.js:10:1)
 `;
 
@@ -70,6 +70,6 @@ FAIL __tests__/index.js
       12 | module.exports = () => 'test';
       13 |
 
-      at createNoMappedModuleFoundError (../../packages/jest-resolve/build/resolver.js:558:17)
+      at createNoMappedModuleFoundError (../../packages/jest-resolve/build/resolver.js:561:17)
       at Object.require (index.js:10:1)
 `;
diff --git a/packages/jest-resolve/src/__tests__/resolve.test.ts b/packages/jest-resolve/src/__tests__/resolve.test.ts
@@ -74,6 +74,20 @@ describe('isCoreModule', () => {
     const isCore = resolver.isCoreModule('constants');
     expect(isCore).toEqual(false);
   });
+
+  it('returns true if using `node:` URLs and `moduleName` is a core module.', () => {
+    const moduleMap = ModuleMap.create('/');
+    const resolver = new Resolver(moduleMap, {} as ResolverConfig);
+    const isCore = resolver.isCoreModule('node:assert');
+    expect(isCore).toEqual(true);
+  });
+
+  it('returns false if using `node:` URLs and `moduleName` is not a core module.', () => {
+    const moduleMap = ModuleMap.create('/');
+    const resolver = new Resolver(moduleMap, {} as ResolverConfig);
+    const isCore = resolver.isCoreModule('node:not-a-core-module');
+    expect(isCore).toEqual(false);
+  });
 });
 
 describe('findNodeModule', () => {

diff --git a/packages/jest-resolve/src/resolver.ts b/packages/jest-resolve/src/resolver.ts
@@ -251,6 +251,9 @@ export default class Resolver {
   }
 
   isCoreModule(moduleName: string): boolean {
+    moduleName = moduleName.startsWith('node:')
+      ? moduleName.slice(5)
+      : moduleName;
     return (
       this._options.hasCoreModules &&
       isBuiltinModule(moduleName) &&