forgot about other notifyMode configs

jestjs · Dec 20, 2017 · 409be3c · 409be3c
1 parent 23a4307
commit 409be3c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/packages/jest-cli/src/cli/args.js b/packages/jest-cli/src/cli/args.js
@@ -349,7 +349,7 @@ export const options = {
     type: 'boolean',
   },
   notifyMode: {
-    default: undefined,
+    default: 'always',
     description: 'Specifies when notifications will appear for test results.',
     type: 'string',
   },

diff --git a/packages/jest-cli/src/reporters/notify_reporter.js b/packages/jest-cli/src/reporters/notify_reporter.js
@@ -40,12 +40,13 @@ export default class NotifyReporter extends BaseReporter {
     const success =
       result.numFailedTests === 0 && result.numRuntimeErrorTestSuites === 0;
 
+    const notifyMode = this._globalConfig.notifyMode;
+
     if (
       success &&
-      (this._globalConfig === 'always' ||
-        this._globalConfig === 'success' ||
-        (this._globalConfig === 'change' &&
-          (!this._previousSuccess || this._firstRun)))
+      (notifyMode === 'always' ||
+        notifyMode === 'success' ||
+        (notifyMode === 'change' && (!this._previousSuccess || this._firstRun)))
     ) {
       const title = util.format('%d%% Passed', 100);
       const message = util.format(
@@ -58,10 +59,9 @@ export default class NotifyReporter extends BaseReporter {
       this._firstRun = false;
     } else if (
       !success &&
-      (this._globalConfig === 'always' ||
-        this._globalConfig === 'failure' ||
-        (this._globalConfig === 'change' &&
-          (this._previousSuccess || this._firstRun)))
+      (notifyMode === 'always' ||
+        notifyMode === 'failure' ||
+        (notifyMode === 'change' && (this._previousSuccess || this._firstRun)))
     ) {
       const failed = result.numFailedTests / result.numTotalTests;
 

diff --git a/packages/jest-config/src/valid_config.js b/packages/jest-config/src/valid_config.js
@@ -58,6 +58,7 @@ export default ({
   name: 'string',
   noStackTrace: false,
   notify: false,
+  notifyMode: 'always',
   onlyChanged: false,
   preset: 'react-native',
   projects: ['project-a', 'project-b/'],

diff --git a/types/Argv.js b/types/Argv.js
@@ -53,6 +53,7 @@ export type Argv = {|
   noSCM: boolean,
   noStackTrace: boolean,
   notify: boolean,
+  notifyMode: string,
   onlyChanged: boolean,
   outputFile: string,
   preset: ?string,