Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outputDirectory and outputName; #62

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Add outputDirectory and outputName; #62

merged 1 commit into from
Sep 21, 2018

Conversation

Vivalldi
Copy link
Contributor

Resolves #61

Introduces

  • JEST_JUNIT_OUTPUT_DIR:outputDirectory - Directory where xml file will be stored
  • JEST_JUNIT_OUTPUT_NAME:outputName - File name of the test results. (Default junit.xml)

This change is introduced in a backwards compatible manner. Personally I think that we should recommend users to move to the new configuration options and depreciate the output/JEST_JUNIT_OUTPUT options.

@Vivalldi
Copy link
Contributor Author

I believe my builds are failing due to an update in jest. By passing the --env node flag to the jest command the tests will pass locally.

@SimenB
Copy link
Member

SimenB commented Sep 20, 2018

This repo should probably specify testEnvironment: node in its config. No reason to run in jsdom.

@SimenB SimenB requested a review from palmerj3 September 20, 2018 13:37
@palmerj3
Copy link
Collaborator

@Vivalldi please rebase and see if the tests pass. I updated the suites to use the node environment here #64

@Vivalldi
Copy link
Contributor Author

That did the trick 👍

@palmerj3 palmerj3 merged commit 074e95d into jest-community:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants