Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #605

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Version Packages #605

merged 1 commit into from
Jun 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 23, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

jest-extended@4.0.0

Major Changes

  • ab20845: Rename toHaveBeenCalledOnceWith to toHaveBeenCalledExactlyOnceWith

Minor Changes

Patch Changes

  • ab20845: Make CustomMatchers extend Record to fix a TypeScript error
  • ab20845: Fix toHaveBeenCalledOnceWith messages
  • ab20845: Change unknown to any in toHaveBeenCalledBefore and toHaveBeenCalledAfter

@GuillaumeRahbari
Copy link
Contributor

Hi @SimenB 👋
Any ETA to merge this one ? :)

@keeganwitt
Copy link
Collaborator

I think we have to make this a major version bump because of #574

@SimenB
Copy link
Member

SimenB commented Jun 5, 2023

Yeah, that PR should have included a changeset. You can probably push a changeset separately to main?

@keeganwitt
Copy link
Collaborator

Yeah, that PR should have included a changeset. You can probably push a changeset separately to main?

Oh I guess I misunderstood the process. I thought we pushed a changeset when we wanted to trigger a release. Which I didn't at the time.

@SimenB
Copy link
Member

SimenB commented Jun 5, 2023

I thought we pushed a changeset when we wanted to trigger a release.

No, together with the changes. Then a PR like this is automatically created, and a release happens when it's merged.

@keeganwitt
Copy link
Collaborator

keeganwitt commented Jun 5, 2023

OK. I think this should do what we need: #612. If we rebase/merge that to this branch, then should be good to go.

Sorry about that.

@SimenB
Copy link
Member

SimenB commented Jun 5, 2023

@keeganwitt if you merge this now, the release should happen

@keeganwitt keeganwitt merged commit bdfb752 into main Jun 5, 2023
@keeganwitt keeganwitt deleted the changeset-release/main branch June 5, 2023 16:50
@SimenB
Copy link
Member

SimenB commented Jun 5, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants