Update CreateUseCase input from value to pointer

Also, update multiple files from the previous mentioned update, including mocks, tests and validation implementation
jessicatarra · Dec 16, 2023 · 6b4223c · 6b4223c
1 parent 2139b28
commit 6b4223c
Show file tree

Hide file tree

Showing 11 changed files with 185 additions and 24 deletions.
diff --git a/ms/auth/internal/application/application.go b/ms/auth/internal/application/application.go
@@ -32,7 +32,7 @@ func NewAppl(userRepo domain.UserRepository, tokenRepo domain.TokenRepository, p
 	}
 }
 
-func (a *appl) CreateUseCase(input domain.CreateUserRequest, hashedPassword string) (*domain.User, error) {
+func (a *appl) CreateUseCase(input *domain.CreateUserRequest, hashedPassword string) (*domain.User, error) {
 	user := &domain.User{Name: input.Name, Email: input.Email, Activated: false}
 
 	err := a.userRepo.InsertNewUser(user, hashedPassword)

diff --git a/ms/auth/internal/application/application_test.go b/ms/auth/internal/application/application_test.go
@@ -71,7 +71,7 @@ func TestAppl_CreateUseCase(t *testing.T) {
 		tokenRepo.On("New", mock.Anything, mock.AnythingOfType("time.Duration"), mock.IsType("string")).Return(nil, nil)
 
 		// Call the CreateUseCase function
-		user, err := app.CreateUseCase(input, hashedPassword)
+		user, err := app.CreateUseCase(&input, hashedPassword)
 
 		// Assert the results
 		assert.NotNil(t, user)
@@ -98,7 +98,7 @@ func TestAppl_CreateUseCase(t *testing.T) {
 		tokenRepo.On("New", mock.Anything, mock.AnythingOfType("time.Duration"), mock.IsType("string")).Return(nil, nil)
 
 		// Call the CreateUseCase function again
-		user, err := app.CreateUseCase(input, hashedPassword)
+		user, err := app.CreateUseCase(&input, hashedPassword)
 
 		// Assert the error step
 		assert.Nil(t, user)

diff --git a/ms/auth/internal/domain/mocks/Appl.go b/ms/auth/internal/domain/mocks/Appl.go
diff --git a/ms/auth/internal/domain/mocks/PermissionRepository.go b/ms/auth/internal/domain/mocks/PermissionRepository.go
diff --git a/ms/auth/internal/domain/mocks/TokenInterface.go b/ms/auth/internal/domain/mocks/TokenInterface.go
diff --git a/ms/auth/internal/domain/mocks/TokenRepository.go b/ms/auth/internal/domain/mocks/TokenRepository.go
diff --git a/ms/auth/internal/domain/mocks/UserRepository.go b/ms/auth/internal/domain/mocks/UserRepository.go
diff --git a/ms/auth/internal/domain/user.go b/ms/auth/internal/domain/user.go
@@ -29,7 +29,7 @@ func (u *User) IsAnonymous() bool {
 }
 
 type Appl interface {
-	CreateUseCase(input CreateUserRequest, hashedPassword string) (*User, error)
+	CreateUseCase(input *CreateUserRequest, hashedPassword string) (*User, error)
 	ActivateUseCase(tokenPlainText string) (*User, error)
 	GetByEmailUseCase(email string) (*User, error)
 	CreateAuthTokenUseCase(userID int64) ([]byte, error)

diff --git a/ms/auth/internal/infrastructure/http/handlers.go b/ms/auth/internal/infrastructure/http/handlers.go
@@ -63,7 +63,7 @@ func (h *handlers) createUser(res http.ResponseWriter, req *http.Request) {
 		return
 	}
 
-	ValidateUser(input, existingUser)
+	ValidateUser(&input, existingUser)
 
 	if input.Validator.HasErrors() {
 		_errors.FailedValidation(res, req, input.Validator)
@@ -76,7 +76,7 @@ func (h *handlers) createUser(res http.ResponseWriter, req *http.Request) {
 		return
 	}
 
-	user, err := h.appl.CreateUseCase(input, hashedPassword)
+	user, err := h.appl.CreateUseCase(&input, hashedPassword)
 	if err != nil {
 		switch {
 		case errors.Is(err, domain.ErrDuplicateEmail):
@@ -109,7 +109,7 @@ func (h *handlers) activateUser(res http.ResponseWriter, req *http.Request) {
 
 	input.TokenPlaintext = h.helpers.ReadString(qs, "token", "")
 
-	ValidateToken(input)
+	ValidateToken(&input)
 
 	if input.Validator.HasErrors() {
 		_errors.FailedValidation(res, req, input.Validator)
@@ -156,7 +156,7 @@ func (h *handlers) createAuthenticationToken(res http.ResponseWriter, req *http.
 		return
 	}
 
-	ValidateEmailForAuth(input, existingUser)
+	ValidateEmailForAuth(&input, existingUser)
 
 	if existingUser != nil {
 		passwordMatches, err := password.Matches(input.Password, existingUser.HashedPassword)