Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Upgrade Gatsby to fix gatsby-announcer bug. #959

Merged
merged 3 commits into from
Jan 24, 2020

Conversation

jessestuart
Copy link
Owner

@jessestuart jessestuart commented Jan 24, 2020

  • Also: test out a new deployment workflow to build everything in
    CircleCI then just push the public dir to Netlify with netlify-cli.

This change is Reviewable

Signed-off-by: Jesse Stuart <hi@jessestuart.com>
Seems there was a 1px div added that was causing
problems with designs containing `100vh` elements.
Related to gatsbyjs/gatsby#20728,
I think.

Signed-off-by: Jesse Stuart <hi@jessestuart.com>
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #959 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #959   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files          68       68           
  Lines         610      610           
  Branches       64       64           
=======================================
  Hits          576      576           
  Misses         27       27           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50886be...17d66ab. Read the comment docs.

@jessestuart jessestuart merged commit d1c2d98 into master Jan 24, 2020
@jessestuart jessestuart deleted the jesse/20200124 branch January 24, 2020 07:12
jessestuart pushed a commit that referenced this pull request Jan 24, 2020
## [1.13.37](v1.13.36...v1.13.37) (2020-01-24)

### Bug Fixes

* **ui:** Take two. ([7efdf57](7efdf57))
* **ui:** Upgrade Gatsby to fix `gatsby-announcer` bug. ([#959](#959)) ([d1c2d98](d1c2d98))
@jessestuart
Copy link
Owner Author

🎉 This PR is included in version 1.13.37 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant