Allow push notifications via Expo #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the push documentation:
For apps built with Expo, push notifications can be sent directly to the Expo push server instead of running the proxy server yourself.
This modifies the web push subscription and worker to add an expo option. A subscription with an expo token does not encrypt the notification, and so doesn't generate the keys for encryption. I did this because I had some trouble generating the kind of keys the server would be happy with. I tried using the
elliptic-expomodule with each of the secp256k1, p256, and curve25519 curves with no luck. There is no sensitive information in the payload since notifications are of the form 'XXXX followed you', so I'm just going to the skip the encryption for non-web-push notifications.