-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest task-lib contains a breaking change #48
Comments
ARGH. Sorry to hear this.
The older version has a security vulnerability, hence the upgrade from my
side. I'll look into this tomorrow.
…On Tue, Apr 14, 2020, 21:45 Danny Fhalpotia ***@***.***> wrote:
Hi,
The update from azure-pipelines-task-lib v2.8.0 to v2.9.3 contains a
breaking change since special characters like % are now being encoded. This
means that when using the set-variable task and the variable value contains
a % sign it will now be encoded whereas it wasn't before the update.
I consider this a breaking change so the task version for set-variable
should really be bumped a major version so we can at least control when we
want to upgrade in Azure DevOps and not have our build break overnight.
Offending Commit: c5e66ba
<c5e66ba>
Ongoing discussion in azure-pipeline-task-lib repo:
microsoft/azure-pipelines-task-lib#627
<microsoft/azure-pipelines-task-lib#627>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#48>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA724S4MDLNOHDNXS7C3FTTRMS4L5ANCNFSM4MIAC66Q>
.
|
Merged
Should be fixed (and configurable) in 1.3.8 which I just pushed. |
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
The update from azure-pipelines-task-lib v2.8.0 to v2.9.3 contains a breaking change since special characters like % are now being encoded. This means that when using the set-variable task and the variable value contains a % sign it will now be encoded whereas it wasn't before the update.
I consider this a breaking change so the task version for set-variable should really be bumped a major version so we can at least control when we want to upgrade in Azure DevOps and not have our build break overnight.
Offending Commit: c5e66ba
Ongoing discussion in azure-pipeline-task-lib repo: microsoft/azure-pipelines-task-lib#627
The text was updated successfully, but these errors were encountered: