Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest task-lib contains a breaking change #48

Closed
dannyfhalpotia opened this issue Apr 14, 2020 · 3 comments · Fixed by #49
Closed

Update to latest task-lib contains a breaking change #48

dannyfhalpotia opened this issue Apr 14, 2020 · 3 comments · Fixed by #49

Comments

@dannyfhalpotia
Copy link

Hi,

The update from azure-pipelines-task-lib v2.8.0 to v2.9.3 contains a breaking change since special characters like % are now being encoded. This means that when using the set-variable task and the variable value contains a % sign it will now be encoded whereas it wasn't before the update.

I consider this a breaking change so the task version for set-variable should really be bumped a major version so we can at least control when we want to upgrade in Azure DevOps and not have our build break overnight.

Offending Commit: c5e66ba

Ongoing discussion in azure-pipeline-task-lib repo: microsoft/azure-pipelines-task-lib#627

@jessehouwing
Copy link
Owner

jessehouwing commented Apr 14, 2020 via email

@jessehouwing
Copy link
Owner

Should be fixed (and configurable) in 1.3.8 which I just pushed.

@dannyfhalpotia
Copy link
Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants