Add option to delete local and remote tag #4217
Merged
+145
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnvarU
force-pushed
the
feature/delete-local-remote-tag
branch
from
c2d3d84 to
dfe7b45
Compare
|
Some screens with workflow:
|
jesseduffield
requested changes
Jan 28, 2025
| Close() | ||
| }). | ||
|
|
||
| // Delete both local and remote tag new-tag-2 |
There was a problem hiding this comment.
Two things:
- I would create this as a separate test because it's fairly independent from what's already in this test.
- We need an assertion that the tag has been removed from the remote. Funnily enough I think that we don't actually show remote tags anywhere, so we'll need to instead settle for a shell command (you can add a function in pkg/integration/components/shell.go called AssertRemoteTagNotFound)
There was a problem hiding this comment.
Thank you for the review!
Sure, I agree with you. I will create a separate test and add a suggested assertion
| @@ -87,6 +87,63 @@ var CrudLightweight = NewIntegrationTest(NewIntegrationTestArgs{ | |||
| Select(Contains("Delete local tag")). | |||
| Confirm() | |||
| }). | |||
| IsEmpty(). | |||
|
|
|||
| // Delete both local and remote tag new-tag-2 | |||
There was a problem hiding this comment.
I wouldn't bother testing this for the lightweight case as it makes no difference in our code.
There was a problem hiding this comment.
Removed, see be5b9ad
jesseduffield
force-pushed
the
feature/delete-local-remote-tag
branch
from
4f235c6 to
93fbc11
Compare
jesseduffield
force-pushed
the
feature/delete-local-remote-tag
branch
from
93fbc11 to
7db8fb8
Compare
jesseduffield
approved these changes
Jan 29, 2025
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to delete both local and remote tag, closes #4203.
go generate ./...)