Fix ssh context not working #577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that I was missing the code of the PR #511 that was merged early June. The code of this branch is a bit cleaner and now works for me |
|
I'll get to the tests in a few days. |
jesseduffield
requested changes
Dec 22, 2024
| @@ -71,33 +71,30 @@ func (c *DockerCommand) NewCommandObject(obj CommandObject) CommandObject { | |||
| return defaultObj | |||
| } | |||
|
|
|||
| // NewDockerCommand it runs docker commands | |||
| // NewDockerCommand creates a DockerCommand struct that wraps the docker client. | |||
| // Able to run docker commands. And handles | |||
There was a problem hiding this comment.
This comment is incomplete
| client.FromEnv, | ||
| client.WithVersion(APIVersion), | ||
| } | ||
| // For an ssh connection the DOCKER_HOST env variable has been overridden. |
There was a problem hiding this comment.
Could you explain the rationale behind these changes? I'm not clear on the reasoning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue as described in #559