Update keybindings.go #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicate keybinding: volumes - c Bind F10 to gui.quit
Repository owner
deleted a comment from
codecov-io
Sep 3, 2019
Repository owner
deleted a comment from
codecov-io
Sep 3, 2019
Repository owner
deleted a comment from
codecov-io
Sep 3, 2019
This comment has been minimized.
This comment has been minimized.
|
Nice, but why F10 tho? |
|
Muscle memory from the Norton Commander / Midnight Commander days |
|
I would say that this can be done by the users themselfs when #117 is merged. No need to make this into a hardcoded config |
|
Ok, but remove the duplicate volume - c keybinding. |
|
Can you make another commit removing this new binding? @Tuurlijk Will merge this afterwards. |
Yea I removed that in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate keybinding: volumes - c
Bind F10 to gui.quit