ensure the current task is stopped before exit #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #147 (kinda)
For some reason we have child processes that are not being killed when lazydocker exits. To fix this, I'm making it so that before closing, lazydocker kills its task manager, which in turn kills the current task if there is any (e.g.
docker logs <container id>
). If the child process isn't killed in three seconds, it prints an error to stdout.I have no idea why the child processes are not being killed when the parent is stopped in the first place. I considered maybe their group id is different, given we assign a group id to some subprocesses like
docker-compose logs
, but it seems that's not the case withdocker logs
. I am open to suggestions :)