Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling beyond the most recent log should not be possible #31

Closed
ed-bassett opened this issue Jul 1, 2019 · 4 comments
Closed

Scrolling beyond the most recent log should not be possible #31

ed-bassett opened this issue Jul 1, 2019 · 4 comments
Labels
good first issue Good for newcomers

Comments

@ed-bassett
Copy link

Steps for reproduction:

  1. Select the Logs tab in the right panel
  2. Scroll in the direction of the more recent log messages using either the keyboard shortcuts or the mouse.
  3. Keep scrolling after the most recent message reaches the top of the screen.

Desired behaviour:
It should not be possible to scroll past the most recent log message. Probably the best option would be to limit scrolling so that the most recent message cannot move further up than the bottom of the screen, but it would also be reasonable enough to limit it so that it can't move further up than the top of the screen.
@mjarkk
Copy link
Contributor

mjarkk commented Jul 1, 2019

This is a problem on ever tab and it also effects scrolling side ways using the arrow keys.

@jesseduffield
Copy link
Owner

This is actually not too tricky to fix, all the code is in scrollUpMain and scrollDownMain in pkg/gui/main_panel.go. I'll chuck a 'good first issue' label on this

@jesseduffield jesseduffield added the good first issue Good for newcomers label Jul 1, 2019
@jesseduffield jesseduffield mentioned this issue Jul 1, 2019
Closed
winhung pushed a commit to winhung/lazydocker that referenced this issue Jul 16, 2019
scrolling does not go beyond the displayed text jesseduffield#31
956ba40
winhung pushed a commit to winhung/lazydocker that referenced this issue Jul 22, 2019
scrolling does not go beyond the displayed text jesseduffield#31
4de994e
winhung pushed a commit to winhung/lazydocker that referenced this issue Jul 25, 2019
added test to increase coverage jesseduffield#31
c9d91f8
winhung pushed a commit to winhung/lazydocker that referenced this issue Jul 26, 2019
added test to increase coverage jesseduffield#31
42e69ac
winhung pushed a commit to winhung/lazydocker that referenced this issue Aug 4, 2019
implemented review comments by adding improved scrolling checking jes…
07bfb92 
…seduffield#31
winhung pushed a commit to winhung/lazydocker that referenced this issue Aug 4, 2019
updated vendor for gocui jesseduffield#31
19dac18
winhung pushed a commit to winhung/lazydocker that referenced this issue Aug 4, 2019
used ViewLinesHeight for scrolling down function jesseduffield#31
082034d
winhung pushed a commit to winhung/lazydocker that referenced this issue Aug 5, 2019
removed scrollCount jesseduffield#31
b899796
winhung pushed a commit to winhung/lazydocker that referenced this issue Aug 6, 2019
scrollDownMain now works properly with ScrollPastBottom enabled jesse…
4e25f78 
…duffield#31
jesseduffield added a commit that referenced this issue Aug 14, 2019
@jesseduffield
Merge pull request #130 from winhung/limit-scrolling
6ebddea 
scrolling does not go beyond the displayed text #31
@jesseduffield
Copy link
Owner

This is done!

@jesseduffield
Copy link
Owner

Also hi @ed-bassett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ed-bassett @jesseduffield @mjarkk