Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General refactor #85

Merged
merged 40 commits into from
Jan 26, 2025
Merged

General refactor #85

merged 40 commits into from
Jan 26, 2025

Conversation

jessedelira
Copy link
Owner

@jessedelira jessedelira commented Jan 18, 2025

Execute Code Quality Steps

  • Does this PR include refactors? Detail them below
  • Does this PR include dependency updates?
  • If the PR includes prisma schema changes, did you create a migration?
  • Run npm run format and npm run lint on your code

Describe Changes

  • Restructured the session completion endpoint and its display component for better functionality- .
  • Added celebration effects and improved session tracking with better error handling and authentication.
  • Enhanced mobile responsiveness and user interface with optimized data fetching and viewport handling.
  • Cleaned up the codebase by removing redundant SQL files.
  • Reorganized CSS structure by consolidating styles into the utils section of global.css.

Refactors

  • Refactor many components to be easier to read/bigger comps now are cleared up

- Simplified the checkbox change handler for workout completion tracking.
- Introduced a new utility function to show confetti upon session completion.
- Enhanced error handling during session completion to revert UI state if needed.
- Updated the authentication logic to ensure credentials are validated before processing.
- Improved type definitions for user-related data in the authentication module.
…r experience

- Updated layout component to utilize full dynamic viewport height and improved navigation styling.
- Modified workout session display to conditionally fetch workouts only when an active session exists, enhancing performance.
- Added meta tags in the app configuration for better mobile web app capabilities and viewport handling.
- Implemented CSS changes to prevent overscroll behavior and ensure proper viewport height handling on mobile devices.
This reverts commit ea627f4.
…e timer display

- Introduced a new user preference for showing elapsed seconds in the active session.
- Updated the user seeding script to include the new preference.
- Refactored the CurrentSessionElapsedTimer component to display elapsed seconds conditionally based on user preferences.
@jessedelira jessedelira marked this pull request as ready for review January 26, 2025 21:29
@jessedelira jessedelira merged commit 280beeb into main Jan 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant