-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General refactor #85
Merged
Merged
General refactor #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified the checkbox change handler for workout completion tracking. - Introduced a new utility function to show confetti upon session completion. - Enhanced error handling during session completion to revert UI state if needed. - Updated the authentication logic to ensure credentials are validated before processing. - Improved type definitions for user-related data in the authentication module.
…r experience - Updated layout component to utilize full dynamic viewport height and improved navigation styling. - Modified workout session display to conditionally fetch workouts only when an active session exists, enhancing performance. - Added meta tags in the app configuration for better mobile web app capabilities and viewport handling. - Implemented CSS changes to prevent overscroll behavior and ensure proper viewport height handling on mobile devices.
This reverts commit ea627f4.
…e timer display - Introduced a new user preference for showing elapsed seconds in the active session. - Updated the user seeding script to include the new preference. - Refactored the CurrentSessionElapsedTimer component to display elapsed seconds conditionally based on user preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute Code Quality Steps
npm run format
andnpm run lint
on your codeDescribe Changes
Refactors