Detach and Reset Spikes in RLeaky #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbre
changed the title
|
Great find - thanks for picking this up. |
|
Would be great if somebody else can take care of this and augment this merge request with it. I quickly glimpsed at it and it looks to be already taken care off and seems to be correct already, but then again I prefer if somebody else can take care of this as I do not plan to spend time on fixing this. Thanks! |
|
Sure - I'll handle it myself once I'm back in the office next week! Thanks. |
|
No worries and thanks for the awesome library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that for the
Rleakyneurons the spike acts as an internal state but was not reset nor detached. I believe the spikes should be reset and detached similar to the membrane potential inreset_hiddenanddetach_hidden, respectively. This merge request adds support for resetting and detaching of the spikes.