Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop duplicate sources #135

Merged
merged 2 commits into from
Oct 4, 2023
Merged

drop duplicate sources #135

merged 2 commits into from
Oct 4, 2023

Conversation

jerpint
Copy link
Owner

@jerpint jerpint commented Oct 4, 2023

No description provided.

hbertrand
hbertrand approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@hbertrand hbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we expect duplicates here, but sure, why not

@jerpint
Copy link
Owner Author

jerpint commented Oct 4, 2023

It happens if you have 2 chunks from a same URL (this happens in the case where you don't have a link to a specific markdown page for example) , so to a user, a same url / title gets displayed twice

@jerpint jerpint temporarily deployed to secrets October 4, 2023 19:26 — with GitHub Actions Inactive
@jerpint jerpint merged commit 83ab01d into main Oct 4, 2023
@jerpint jerpint deleted the drop-duplicate-sources branch October 4, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbertrand hbertrand hbertrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerpint @hbertrand