PluginsResource: Treat moment.js as independent plugin #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
On the
PluginsResourceclass treatMoment.jsas an independent plugin, and use it as a dependency for other plugins like the Date Range Picker and Tempus Dominus.This will also solve an issue that appears when you installs, for example, Date Range Picker. Note, the Moment.js will also be installed as a resource of the previous plugin. Under this situation, the plugin status entry for the Tempus Dominus plugin will be shown as
MismatchbecauseMoment.jsis also a resource required by it, and the implemented logic incorrectly assumes that the plugin was partially installed.With the new implementation, Moment.js will also be installed as a dependency when installing Date Range Picker or Tempus Dominus, but Moment.js will not be considered as a resource of these plugins. This way, the installation status of each of these plugins will be more representative.
Checklist