Improve package resources #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to return boolean, it's better to let an exeption happen
resslinger
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
A set of improvements over the package resources classes:
src/Console/PackageResources/AssetsResource.phptosrc/Console/PackageResources/AdminlteAssetsResource.php, this way the class results more meaningful.src/Console/PackageResources/BasicRoutesResource.phptosrc/Console/PackageResources/AuthRoutesResource.php, this way the class results more meaningful. Now, this resource will be only used to install the authentication routes that are required to work with theLaravel/UIpackage.src/Console/PackageResources/BasicViewsResource.phpand related stuff, it was just installing a very basic example view of layout usage. There's no worth having it since more detailed examples on how to use the layout are provided in the WIKI pages.src/Console/PackageResources/MainViewsResource.php. Now this resource will avoid publishing the views related to the blade-x components. This class was also renamed toLayoutViewsResource.Checklist