Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve menu filters (last stage) #1274

Merged
merged 2 commits into from
May 1, 2024

Conversation

dfsmania
Copy link
Collaborator

@dfsmania dfsmania commented Apr 29, 2024

Question Answer
Pull request type ENHANCEMENT
License MIT

What's in this PR?

Improve the ActiveChecker class:

  • Internal UrlGenerator instance was removed, instead url() helper from Laravel is used now.
  • Internal Request instance was removed, instead request() helper from Laravel is used now.
  • Improve the logic of the class.

Improve the HrefFilter class:

  • Internal UrlGenerator instance was removed, instead url() helper from Laravel is used now.
  • Improve the internal filter logic.

Tests were modified to adapt to the previous improvements:

  • The HrefFilter tests were separated into a different test class.
  • Since the ActiveChecker and HrefFilter constructor methods were changed, most of the test were adapted.

Checklist

  • I tested these changes.

@dfsmania dfsmania marked this pull request as draft April 29, 2024 15:43
@dfsmania dfsmania marked this pull request as ready for review April 29, 2024 18:41
@dfsmania dfsmania requested a review from resslinger April 29, 2024 18:41
@dfsmania dfsmania merged commit a710271 into jeroennoten:master May 1, 2024
34 checks passed
@dfsmania dfsmania deleted the improve_filters_last_stage branch May 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants