Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the Lang menu filter (stage 2) #1269

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Improve the Lang menu filter (stage 2) #1269

merged 1 commit into from
Apr 20, 2024

Conversation

dfsmania
Copy link
Collaborator

@dfsmania dfsmania commented Apr 13, 2024 •
edited
Loading

Question Answer
Pull request type ENHANCEMENT
License MIT

What's in this PR?

Improves the LangFilter of the menu:

  • Simplify the filter constructor by eliminating the Translator instance, now we use the Lang Facade instead.
  • Better code documentation on the filter.
  • Split tests related to this filter on a separated class.

Checklist

  • I tested these changes.

@dfsmania dfsmania requested a review from resslinger April 13, 2024 21:22
@dfsmania dfsmania merged commit a74eae3 into jeroennoten:master Apr 20, 2024
34 checks passed
@dfsmania dfsmania deleted the improve_menu_filter_lang branch April 20, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resslinger resslinger Awaiting requested review from resslinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dfsmania