Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of codebase #1265

Merged
merged 6 commits into from
Apr 13, 2024
Merged

Conversation

dfsmania
Copy link
Collaborator

@dfsmania dfsmania commented Apr 1, 2024

Question Answer
Pull request type ENHANCEMENT
License MIT

What's in this PR?

  • Refactor the AdminLte class.
    • Arguments of the constructor were simplified taking advantage of some Laravel's helpers.
    • Now, an instance of the menu builder is part of the class, instead of holding the filters and the built menu that were already part of the menu builder.
    • Now, the logic to build the menu is easier to understand. Dispatching the building menu event and listening for it on the service provider to compile the static menu configuration was weird.
    • Better code documentation.
  • Refactor the AdminLteServiceProvider class.
    • Remove listener for the building menu event.
    • Simplifies logic to compose views with the AdminLte class instance.
  • Change and improve tests for the previous changes.

Checklist

  • I tested these changes.

@dfsmania dfsmania marked this pull request as draft April 1, 2024 23:06
@dfsmania dfsmania marked this pull request as ready for review April 2, 2024 21:31
@dfsmania dfsmania requested a review from resslinger April 2, 2024 21:32
@dfsmania dfsmania merged commit 6b9ac92 into jeroennoten:master Apr 13, 2024
34 checks passed
@dfsmania dfsmania deleted the refactor-codebase branch April 13, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants