Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @stack('content') #1235

Merged
merged 3 commits into from
Dec 8, 2023
Merged

add @stack('content') #1235

merged 3 commits into from
Dec 8, 2023

Conversation

AMoktar
Copy link
Contributor

@AMoktar AMoktar commented Dec 3, 2023

Question Answer
Issue or Enhancement Enhancement
License MIT

What's in this PR?

jsut added single line @stack('content') to enable @push to 'content'

Checklist

  • I've tested changes manually, since I didn't manage to figureout how jeroennoten/Laravel-AdminLTE/tests work, I'm getting errors like
    Failed asserting that directory "test-folder-copy" does not exist.

I'd be happy if you helped me for running /tests
Thanks

@dfsmania dfsmania self-requested a review December 3, 2023 14:55
@dfsmania dfsmania self-assigned this Dec 3, 2023
@dfsmania dfsmania marked this pull request as draft December 3, 2023 14:57
@dfsmania
Copy link
Collaborator

dfsmania commented Dec 3, 2023

@AMoktar Please revert the active checker change, since it break backward compatibility and fails on tests. I will try to found a solution for your special use case when I get some free time from work...

Then, I will check if stack() may be useful for other yielded sections too...

Copy link
Collaborator

@dfsmania dfsmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the changes on the ActiveChecker class

@AMoktar AMoktar marked this pull request as ready for review December 6, 2023 06:10
@dfsmania
Copy link
Collaborator

dfsmania commented Dec 6, 2023

@AMoktar Please, give me some time. Before merging I would like to check if it's convenient to add @stack() to other yielded sections too.

@dfsmania
Copy link
Collaborator

dfsmania commented Dec 8, 2023

Ok, I did not find any other section where adding @stack() may be useful. In content it makes sense, so you can keep extending an already defined view to @push() additional content to it.

@dfsmania dfsmania merged commit 537d21c into jeroennoten:master Dec 8, 2023
26 checks passed
@dfsmania dfsmania linked an issue Jan 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Possibility to @push to content section
2 participants