New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#include <math.h> for ceil, fmin, fmax, fabs, log10 #428

Open

MichaelChirico wants to merge 1 commit into jeroen:master from MichaelChirico:patch-2

Contributor

MichaelChirico commented Oct 10, 2023 •

edited

Loading

We could also add these indirectly-included headers:

<stdio.h> for snprintf
<string.h> for strspn, strlen, strcat

These three (<math.h>, <stdio.h>, <string.h>) could replace <stdlib.h>.

We could also add specific headers for R:

<R_ext/Arith.h> for NA_LOGICAL, NA_INTEGER, ISNA, ISNAN, R_FINITE, R_PosInf, R_NegInf
<R_ext/Error.h> for error

Feel free to request any of these changes, or to just close if transitive inclusion via <stdlib.h> is fine with you.


          #include <math.h> for ceil, fmin, fmax, log10

f71f30a

MichaelChirico changed the title ~~#include <math.h> for ceil, fmin, fmax, log10~~ #include <math.h> for ceil, fmin, fmax, fabs, log10

jeroen force-pushed the master branch from e6f89b3 to 86e5067 Compare

December 4, 2023 12:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet