Fix a unit test for winbuilder

jeroen · Aug 23, 2024 · 09f8c46 · 09f8c46
1 parent 039a5a2
commit 09f8c46
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/NEWS b/NEWS
@@ -1,5 +1,6 @@
 5.2.2
  - Disable a compression test for libcurl 8.7.1 which has a bug for deflate
+ - Change a unit test to work better on winbuilder
 
 5.2.1
  - In handle_setheader(), setting a header to a non-empty whitespace string will

diff --git a/tests/testthat/test-certificates.R b/tests/testthat/test-certificates.R
@@ -10,11 +10,11 @@ test_that("CloudFlare / LetsEncrypt certs", {
 })
 
 test_that("Invalid domain raises an error", {
-  ipaddr <- nslookup("www.google.com", ipv4_only = TRUE)
-  fake_url <- paste0("https://", ipaddr)
-  expect_error(curl_fetch_memory(fake_url), "certificate")
-  expect_is(curl_fetch_memory(fake_url, handle = new_handle(
-    ssl_verifyhost = FALSE, ssl_verifypeer = FALSE))$status, "integer")
+  ipaddr <- nslookup("www.r-project.org", ipv4_only = TRUE)
+  h <- new_handle(resolve = paste0("fakehostname:443:", ipaddr))
+  expect_error(curl_fetch_memory("https://fakehostname", handle = h), "certificate")
+  handle_setopt(h, ssl_verifyhost = FALSE, ssl_verifypeer = FALSE)
+  expect_is(curl_fetch_memory("https://fakehostname", handle = h)$status, "integer")
 })
 
 test_that("GC works", {