Bring back the older way of handling websocket_terminate #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be a glitch in the CI build. I can try force-pushing the commit trigger another build. |
| _ -> | ||
| case Reason of | ||
| normal -> ok; | ||
| _ -> error_info(Handler, Reason, HandlerState) |
There was a problem hiding this comment.
Is there a reason you wanted to suppress the error log?
|
👍 getting error messages truncated because state was too large and missing out on the stacktrace has made things terrible to debug... |
dapdizzy
pushed a commit
to dapdizzy/websocket_client
that referenced
this pull request
Jul 31, 2017
Keep a local copy of rebar3 for travis-ci to use
The older behaviour seems to have been changed unintentionally, in 699569e
MaxSt
force-pushed
the
alco/websocket-terminate-fix
branch
from
81d25ef
to
dfbb053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older behaviour seems to have been changed unintentionally,
in 699569e