fix: Use ASCII apostrophe for console message #6076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it might not be displayed correctly depending on the console encoding.
Marcono1234
changed the title
jeremylong
approved these changes
Nov 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
none
Description of Change
Relates to #3902
The Unicode apostrophe
’might not be displayed correctly, depending on the encoding of the console. For example on Windows either a '?' or apparently also a 'Æ' is displayed.Notes:
’also appears in the HTML and Jenkins report, but since those specifycharset=UTF-8, I assume it is not a problem thereHave test cases been added to cover the new functionality?
no