n+1 tests #185
n+1 tests #185
Conversation
| echo "\e[32mSeeding:\e[0m DefaultConnectRelationshipsSeeder - Role:Admin attached to Permission:".$permission->slug."\r\n"; | ||
| $this->command->getOutput()->writeln( | ||
| "<info>Seeding:</info> DefaultConnectRelationshipsSeeder - Role:Admin attached to Permission:" | ||
| . $permission->slug |
There was a problem hiding this comment.
Multi-line function call not indented correctly; expected 16 spaces but found 20
| echo "\e[32mSeeding:\e[0m DefaultPermissionitemsTableSeeder - Permission:".$Permissionitem['slug']."\r\n"; | ||
| $this->command->getOutput()->writeln( | ||
| "<info>Seeding:</info> DefaultPermissionitemsTableSeeder - Permission:" | ||
| . $Permissionitem['slug'] |
There was a problem hiding this comment.
Multi-line function call not indented correctly; expected 20 spaces but found 24
| use Illuminate\Database\Schema\Blueprint; | ||
| use Illuminate\Support\Facades\Schema; | ||
|
|
||
| class CreateUsersTable extends Migration |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
| } | ||
|
|
||
| /** @test */ | ||
| public function can_preload_roles_on_collection(): void |
There was a problem hiding this comment.
Method name NPlusOneQueriesTest::can_preload_roles_on_collection is not in camel caps format
| } | ||
|
|
||
| /** @test */ | ||
| public function can_attach_roles() |
There was a problem hiding this comment.
Method name NPlusOneQueriesTest::can_attach_roles is not in camel caps format
| } | ||
|
|
||
| /** @test */ | ||
| public function it_caches_roles() |
There was a problem hiding this comment.
Method name NPlusOneQueriesTest::it_caches_roles is not in camel caps format
| } | ||
|
|
||
| /** @test */ | ||
| public function it_caches_permissions() |
There was a problem hiding this comment.
Method name NPlusOneQueriesTest::it_caches_permissions is not in camel caps format
| } | ||
|
|
||
| /** @test */ | ||
| public function can_preload_permissions_on_collection(): void |
There was a problem hiding this comment.
Method name NPlusOneQueriesTest::can_preload_permissions_on_collection is not in camel caps format
Note:
echoin seeders with command outputseed.handlerto prevent errorsphpunit.xmlStill cannot reproduce #179
Detected problem: cannot preload
rolePermissionsanduserPermissions.rolePermissionsis not relation at all and cannot be preloaded via eager load