Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make stream is send #10

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

giangndm
Copy link
Contributor

This PR makes the stream with Send.

Why we need this: It allows us to use the stream inside a Tokio-spawned task without local_set.

@jeremychone jeremychone merged commit 71976b7 into jeremychone:main Aug 13, 2024
@jeremychone
Copy link
Owner

@giangndm Thank you. Just merged it, will be in the next release.

Btw, next release will change the way AuthResolver work. I will update the example and changelog. Ping me if any issue.

@jeremychone
Copy link
Owner

@giangndm By the way, if you don't mind, could you update the README in your genai-custom to let developers know the official one is genai?

It's unfortunate that we can't delete crates, but perhaps you could yank your version as well to make it clearer.

@giangndm
Copy link
Contributor Author

@jeremychone Sure, I will update README for custom version and make it yanked after update my dependency

@jeremychone
Copy link
Owner

@giangndm awesome, thanks!

@jeremychone jeremychone added the PR-MERGED Added for PR that somehow did not get the Merge label Sep 1, 2024
@jeremychone
Copy link
Owner

@giangndm I’m sure you forgot, but could you yank your genai-custom? It’s strange that somehow Google put the link above the official genai library. If you could yank all versions and maybe push another one with a new README that points to the crates.io genai, that would be great.

@giangndm
Copy link
Contributor Author

@jeremychone Sorry I have a very busy time. I just yanked the package and will update README and crate.io soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-MERGED Added for PR that somehow did not get the Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants